Issue 13785

jumbled up appearance of contact details

13785
Reporter: feedback bot
Assignee: mdoering
Type: Feedback
Summary: jumbled up appearance of contact details
Priority: Minor
Resolution: Fixed
Status: Closed
Created: 2013-09-06 13:46:40.646
Updated: 2014-07-07 11:36:00.469
Resolved: 2013-09-13 12:59:26.008
        
        
Description: If we add html tags on the contact info on IMS (like the addresses of the contacts) they are displayed nicely for example: under the name Francisco Pando on the spanish page. If we don't do that, they are displayed altogether, with no break lines e.g. under the name Luis Eduardo Ruiz López de la Torre Ayllón on this page, and we have received complaints about that. This is true for most of the country pages. How can we resolve it without having to add html tags everywhere on the IMS?

*Reporter*: Lina Ilia]]>
    

Attachment Screen Shot 2013-09-06 at 15.39.41.png



Author: mdoering@gbif.org
Created: 2013-09-06 14:18:21.036
Updated: 2013-09-06 14:18:21.036
        
In general there should be no html tags in the IMS at all. We need to avoid that as it will show up also in the json webservices and cause a headache for any user that might want to render it differently:
http://apidev.gbif.org/node/country/ES

Surely better would be a regular linebreak \n, ideal would be a repeated address field, so every address part/line has its own "record".
I'll discuss this internally a bit...
    


Author: mdoering@gbif.org
Created: 2013-09-06 14:36:20.621
Updated: 2013-09-06 14:36:20.621
        
Let's solve this in two steps. Ultimately the address in our API will have a list of address lines that we can render nicely.
Because we dont want to implement new forms in the IMS we suggest to use a pipe | symbol to delimit individual address lines. This will then be converted into proper multiple lines in our webservices.

For this to happen gracefully we will need to udpate our API and registry database which takes a few days, so I will setup our portal now to replace an pipe with an html line break so it renders nicely already.

Please start using the pipe excusively to delimit new lines and replace the 
html with {noformat}|{noformat}


Author: ahahn@gbif.org
Comment: (for editors: on Windows systems, the "pipe" character can be entered by holding the "AltGr" key down and typing the one marked "><\")
Created: 2013-09-06 14:47:01.92
Updated: 2013-09-06 14:51:14.506


Author: mdoering@gbif.org
Comment: portaldev now shows pipes as new lines: https://code.google.com/p/gbif-portal/source/detail?r=1977
Created: 2013-09-06 14:53:53.697
Updated: 2013-09-06 14:53:53.697


Author: ahahn@gbif.org
Created: 2013-09-06 15:50:51.644
Updated: 2013-09-06 15:50:51.644
        
Revert: we are not going to use pipe characters, but instead interpret the carriage returns contained in the IMS contact data. See left hand side contact in the attached screenshot (right hand side currently broken because of test-
characters contained in the IMS). NB: as the database content may depend on the system used by the person entering the data, this may still show strange effects. Currently, only the output appearing as "\r" in output like http://staging.gbif.org:8080/registry2-ws/node/country/ES can be handled. Combining alternative versions, including "\n" or "\n\r" would be a different issue.


Author: mdoering@gbif.org
Comment: https://code.google.com/p/gbif-portal/source/detail?r=2065
Created: 2013-09-13 12:59:26.041
Updated: 2013-09-13 12:59:26.041