18036
Reporter: kylecopas
Assignee: bko
Type: Improvement
Summary: Democratic Republic of Congo, The?
Priority: Unassessed
Resolution: Fixed
Status: Closed
Created: 2015-11-13 11:33:09.069
Updated: 2016-02-23 15:18:23.309
Resolved: 2016-02-23 15:18:23.185
Description: Our newest national participant is showing up alphabetised under 'T' for 'The Democratic Republic of Congo', making it difficult to find.
Can we adjust the ISO list so that it shows up alphabetized under D or C, whether by deleting 'The' or listing it as either 'Democratic Republic of Congo, The' or 'Congo, The Democratic Republic of'?]]>
Author: bko@gbif.org
Created: 2015-12-04 10:30:50.143
Updated: 2015-12-04 10:56:20.836
I am seconded to the suggestion and would like put two Congos together, i.e. sort by "C".
However, the format of country name for the Democratic Republic of Congo is in consistent across our systems:
Registry: The Democratic Republic of the Congo
ISO: Congo (The Democratic Republic of the)
Drupal country: Congo, The Democratic Republic of the
IMS participant: Democratic Republic of the Congo
This causes some minor issues due to the failing of name look-ups across country name sources.
Should we decide a consistent name for this country? I am tagging [~trobertson@gbif.org] and [~anmnielsen] to get their attention.
Author: thirsch@gbif.org
Created: 2015-12-04 11:10:03.008
Updated: 2015-12-04 11:10:03.008
I agree we should keep consistent terminology across all platforms and would suggest the following for the two countries:
Congo, Democratic Republic of the
Congo, Republic of the
Author: bko@gbif.org
Comment: I'll ensure the names are consistent across our systems.
Created: 2015-12-10 07:34:05.261
Updated: 2015-12-10 07:34:05.261
Author: trobertson@gbif.org
Created: 2015-12-10 07:40:40.112
Updated: 2015-12-10 07:40:40.112
To save you some time:
https://github.com/gbif/gbif-api/blob/master/src/main/java/org/gbif/api/vocabulary/Country.java#L311
I'd expect in all DB's and HBase we store only the 2 Char ISO code, so it should be a safe change
e.g. registry: https://github.com/gbif/registry/blob/master/registry-ws/src/main/resources/liquibase/schema.sql#L37
Author: bko@gbif.org
Created: 2015-12-10 10:06:51.11
Updated: 2015-12-10 10:06:51.11
http://api.gbif.org/v1/enumeration/country
It doesn't seem to follow the suggestion from TH?
Author: kylecopas
Created: 2015-12-10 10:09:37.155
Updated: 2015-12-10 10:09:37.155
No, not yet it doesn't ;-)
The proposal was for
• Congo, Democratic Republic of the
• Congo, Republic of the
Author: trobertson@gbif.org
Comment: That is correct [~bko@gbif.org]. I was giving you a quick link to the code you are going to need to change
Created: 2015-12-10 10:15:49.524
Updated: 2015-12-10 10:15:49.524
Author: bko@gbif.org
Created: 2015-12-17 15:24:48.319
Updated: 2015-12-17 15:24:48.319
Fixed by updating the country enumeration following TH's suggestion.
On GBIF API:
https://github.com/gbif/gbif-api/commit/b0a3b5dca85d440e176f82f3bcbfdd6727abe02d
And the Drupal country vocabulary and FileMaker (thanks to [~atalavan]) done manually.
Author: kylecopas
Comment: Like, +1, favourite—all of those at once!
Created: 2015-12-17 15:28:56.608
Updated: 2015-12-17 15:28:56.608
Author: mblissett
Created: 2016-02-02 12:37:58.208
Updated: 2016-02-02 12:37:58.208
I've changed the enum value back to CONGO, since we shouldn't change the API unnecessarily (the enum values are the ISO "short names", and that's still CONGO: https://www.iso.org/obp/ui/#iso:code:3166:CG )
The title and user-visible changes are unchanged.
Author: kylecopas
Comment: Seeing 'CG' has me worried—the fix was aimed at moving 'CD' (Democratic Republic of Congo) up in alpha order, so it was adjacent to CG (Republic of Congo). Your last change hasn't concatenated them, has it, @mblissett?
Created: 2016-02-02 13:09:41.027
Updated: 2016-02-02 13:09:41.027
Author: mblissett
Comment: No, the change to ordering and titles remains in place: http://www.gbif-uat.org/country
Created: 2016-02-02 17:02:05.926
Updated: 2016-02-02 17:02:05.926
Author: bko@gbif.org
Created: 2016-02-04 14:17:55.816
Updated: 2016-02-04 14:18:35.258
/country is served by a static file from Drupal and has been changed to use live API during the Directory API development.
http://drupaledit.gbif-dev.org/country
From DEV(on directory branch) I can see the order of Congo has been changed. So here I reopen this issue again and will make sure the two Congos are in the order we want.
Author: kylecopas
Comment: As long as they both appear as 'Congo, the...'—that is, sorted broadly to alphabetical order under letter 'C', rather than 'T' ('The Democratic Republic of the Congo')—we're good.
Created: 2016-02-04 16:33:28.649
Updated: 2016-02-04 16:33:28.649
Author: bko@gbif.org
Created: 2016-02-05 11:38:06.137
Updated: 2016-02-05 11:38:06.137
It will. We just found that the registry still uses the API release earlier then what I have committed, hence the reason why from registry we still have "The Democratic Republic of the Congo". This will be updated when we roll out the Directory API and the name and sorting will be what we expect.
CC [~fmendez@gbif.org].
Author: mblissett
Comment: Everything is now updated, and looks to be OK.
Created: 2016-02-23 15:18:23.291
Updated: 2016-02-23 15:18:23.291