13731
Reporter: omeyn
Assignee: javierarce
Type: Feedback
Summary: Social media buttons too big on IE8
Description: The icons for twitter, facebook etc are too big, and maybe missing some kind of style effect?
Priority: Minor
Resolution: Fixed
Status: Closed
Created: 2013-08-30 13:50:14.517
Updated: 2013-09-05 17:45:43.292
Resolved: 2013-09-05 17:45:43.26
Author: javierarce
Created: 2013-09-02 16:44:29.086
Updated: 2013-09-02 16:44:29.086
Fixed. Since IE8 doesn't support background-size I've decided to use custom icons for IE8 and add a rule in hack.less to use those images.
Author: omeyn@gbif.org
Comment: still showing wrong for me
Created: 2013-09-04 14:52:31.681
Updated: 2013-09-04 14:52:31.681
Author: javierarce
Created: 2013-09-04 16:52:32.708
Updated: 2013-09-04 16:52:32.708
This is what I see in my development server (in IE8): http://cl.ly/image/3K230z37371p and here's the commit: https://code.google.com/p/gbif-portal/source/detail?r=1924
I added some assets (twitter_small.png, for example) that aren't in the server: http://portaldev.gbif.org/img/footer/twitter_small.png
Maybe that change wasn't deployed?
Author: mdoering@gbif.org
Created: 2013-09-04 22:27:16.566
Updated: 2013-09-04 22:27:16.566
It somehow indeed did not deploy. Maybe that effects other issues you solved too. It is in SVN and the portal has built since, but it is not in the actual deloyed webapp:
http://staging.gbif.org:8080/portal/img/footer/twitter_small.png
the old one does exist:
http://staging.gbif.org:8080/portal/img/footer/twitter.png
Im rebuiliding the portal, something went wrong in the last deploys
Author: mdoering@gbif.org
Created: 2013-09-05 00:23:39.743
Updated: 2013-09-05 00:23:39.743
its there: http://portaldev.gbif.org/img/footer/twitter_small.png
we had a bad jenkins deploy configuration that deployed to a portal-web context instead of /portal
Author: javierarce
Created: 2013-09-05 09:42:16.985
Updated: 2013-09-05 09:42:16.985
Perfect. I didn't know that the home page comes from Drupal, so that's why currently there are no social icons in http://portaldev.gbif.org.
I'll fix it now.
Author: omeyn@gbif.org
Comment: I can confirm that the icons look better in IE8 now, but the Vimeo icon looks a bit pixelated/distorted. And can confirm that they behave normally in other browsers when looking at the java side, but missing from drupal side.
Created: 2013-09-05 10:50:46.282
Updated: 2013-09-05 10:50:46.282
Author: javierarce
Comment: Fixed. The missing icons appear in the drupal site & the vimeo looks better now.
Created: 2013-09-05 17:45:36.391
Updated: 2013-09-05 17:45:36.391
