DatasetService has inconsistent listSubdatasets() and listConstituents(UUID) methods

13776
Reporter: mdoering
Type: Feedback
Summary: DatasetService has inconsistent listSubdatasets() and listConstituents(UUID) methods
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2013-09-05 15:31:04.297
Updated: 2013-09-30 16:14:23.271
Resolved: 2013-09-30 16:14:23.246
        
Description: There are 2 methods for accessing constituents of a dataset in DatasetService:

{noformat}
  /**
   * Pages through constituents of a dataset, i.e. returns datasets which have a parentDatasetKey
   * equals to the one requested.
   *
   * @param datasetKey the parent datasets key
   */
  PagingResponse listConstituents(UUID datasetKey, @Nullable Pageable page);
{noformat}

and

{noformat}
  /**
   * Provides access to datasets that are marked as a sub dataset (e.g. have a parent dataset).
   */
  PagingResponse listSubdatasets(@Nullable Pageable page);
{noformat}

Suggest to rename listSubdatasets into listConstituents or make the UUID in the existing listConstituents Nullable
]]>
    

Author: omeyn@gbif.org
Comment: /dataset/<uuid>/subdataset doesn't work (not on the resource) so i'm removing that from api docs and leaving /dataset/<uuid>/constituents
Created: 2013-09-30 16:13:22.352
Updated: 2013-09-30 16:13:22.352