14045
Reporter: mdoering
Assignee: cvizitiu
Type: Bug
Summary: Use conventional html layout in drupal
Priority: Critical
Resolution: Invalid
Status: Resolved
Created: 2013-09-24 17:49:02.489
Updated: 2014-04-14 11:08:21.007
Resolved: 2014-04-14 11:08:20.975
Description: This primarily applies to the data sharing agreement, but it might be that it effects more or even all editorial pages in Drupal. The identified problems:
- green infoband is empty when this should contain the main title of the page with an optional subheading
- articles use a new detail class that does not seem to be needed if the html is crafted according to below conventions
- main article title should be using h2, not h1. It then shows up fine without any new article class
- lastminutefix .full should be removed and instead the div class currently holding "left" should be "fullwidth"
- subheadings within an article should use h3 without any further markup, not p combined with strong as in "Background"]]>
Author: cvizitiu@gbif.org
Created: 2013-09-24 19:54:45.239
Updated: 2013-09-24 19:54:45.239
green infoband is empty when this should contain the main title of the page with an optional subheading
Main title as in what? The title is already being used in the first block. Should it be repeated?
articles use a new detail class that does not seem to be needed if the html is crafted according to below conventions
Markus, don't mind me asking? Is the template set handed to me of any value or not? Because I remember that template being discussed to the minute by Tim Hirsh with the vizzuality folks. Are we getting away from that set of templates? If yes, is there a set of clearly defined templates that I can reference to each time I have a layout problem?
main article title should be using h2, not h1. It then shows up fine without any new article class
No problem...
lastminutefix .full should be removed and instead the div class currently holding "left" should be "fullwidth"
Let me see...
subheadings within an article should use h3 without any further markup, not p combined with strong as in "Background"
I'm sorry but this is way deeper: 1. The RTE emits it's very own HTML in many places. 2. It requires that we "tune" the rich text editor's set of styles with a clearly defined set of styles we agree on. Let me come back to the previous question: do I have a new reference template set now that we're doing away with the newsroom set which was given by Vizzuality?
Author: mdoering@gbif.org
Created: 2013-09-25 10:37:11.663
Updated: 2013-09-25 11:28:50.797
2- it might be best to add a small ToC to the first article and split it in left and right? Similar to what we do on the API pages: http://portaldev.gbif.org/developer/species
[~thirsch@gbif.org] could comment on this one.
3- RTE: understandable, but we need to tame that content to make it look like it was "regular" markup.
Two options: a) alter/rewrite TinyMCE so that it produces EXACTLY the HTML you want or b) we accept that there is no absolute final way of doing HTML and instead try and give the editorial staff some CSS classes to use in their editing process.
If it would be me I would not even use the RTE but rather manage html directly in svn instead so we can guarantee good markup.
[~thirsch@gbif.org] your call: Should we move the agreement page(s) from within regular, editor staff changeable Drupal content and have them as static HTML (editable only or mainly by the programming team)?
How about we rename that article "detail" class to "rte" instead to make it clear this class fixes specifics of the RTE generated markup?
How urgent?
4- and no, I dont think we have any up to date reference templates anymore. Its all in flux. I was mostly trying to avoid creating new main styles for pages when existing ones should do the work already. Primarily we need to fix the endresult and this important, prominently exposed page looks pretty bad if you ask me
Well, what can I say... it's 180 degrees from what I used to do... the said "ugliness" is EXACTLY the reason for which normally one has a set of templates: You let the designers/visual architects/whatever do their job cos' that's what they know best and then you implement exactly that set of template(s) in code. And that's what happened: [~thirsch@gbif.org] signed off so to say on a series of templates which were discussed with Vizzuality... :-o
Changing html and css on the fly in order to improve aesthetics means IMHO we rushed into coding without knowing what you want... and the proposed "flux" (trying to keep up to date Drupal templates by peeking at changes in Java/JSP pages with no reference to compare with) looks to me like won't scale up very well in terms of efficiency; not entirely sure how well this "agile programming" mindset applies here; just my 2c, of course.
Author: trobertson@gbif.org
Created: 2013-09-25 11:19:45.764
Updated: 2013-09-25 11:19:45.764
For starters, as discussed with [~ahahn@gbif.org], [~thirsch@gbif.org] and [~cvizitiu@gbif.org].
Please make the URLs
/agreement/use
/agreement/sharing
Please make it a single tabbed page ("Use", "Sharing").
Please make the heading: "Agreements"
Please make the sub heading: "Terms for sharing and using data through GBIF"
For the styling, I understand they are simply bulleted lists, and somewhere a CSS seclector is screwing bulleted lists. That remains open before this issue can be closed.
Author: ahahn@gbif.org
Created: 2013-09-25 11:53:52.923
Updated: 2013-09-25 11:53:52.923
Data Use Agreement, new link: /agreement/use
needs to be updated at
- Drupal footer > Key Documents > Data use agreement
- Java footer > Key Documents > Data use agreement
- "BETA" sticker disclaimer, pint iii behind "_here_"
- to be added at: http://uat.gbif.org/usingdata/summary
Data Sharing Agreement, new link: ../agreement/sharing
needs to be updated at
- Drupal footer > Key Documents > Data sharing agreement
- Java footer > Key Documents > Data sharing agreement
- to be added at: http://uat.gbif.org/publishingdata/howtopublish
(and possibly more, but those are all I can come up with so far)
Author: cvizitiu@gbif.org
Created: 2013-09-25 12:28:00.037
Updated: 2013-09-25 12:28:00.037
As suggested by [~trobertson@gbif.org] tabs and page title:
http://staging.gbif.org/agreement/use
Author: mdoering@gbif.org
Created: 2013-09-25 13:26:00.324
Updated: 2013-09-25 13:26:00.324
Looking much better already, still I'd like to propose improvements:
- remove "Background" in first article completely
- use fullwidth articles all over, but
- use a left/right article at the top and include a quick links section at the right
- remove specific css classes and stick to simple defaults as we use elsewhere, namely:
- remove all body and articles classes
- make article headers use h2 for the title
I will make sure the color if the list items is corrected in the main css, thats a bug
Author: cvizitiu@gbif.org
Created: 2013-09-25 13:32:02.033
Updated: 2013-09-25 13:32:02.033
body's class is defined at template level, so:
a) create some particular templates just for agreements
b) create a new document type to be used for agreements (still requires a template)
c) remove body's class from all over the places.
Personally I'd like to see c) implemented but that's because it'll simplify things quite a lot, template wise.
Author: mdoering@gbif.org
Comment: The last suggestion is to make use of a html definition list (dl) for the "Definitions" in the last article. See attached screenshot for how it would look (without the color css change still)
Created: 2013-09-25 13:54:36.727
Updated: 2013-09-25 13:54:36.727
Author: mdoering@gbif.org
Comment: c) sounds best to me, happy to adjust some css where needed. Do we use a seperate template for the news and data use articles? Would be good not to interfer with those
Created: 2013-09-25 13:56:15.48
Updated: 2013-09-25 13:56:15.48
Author: kbraak@gbif.org
Comment: [~cvizitiu@gbif.org] any update on this issue? Thanks
Created: 2013-12-20 16:05:58.366
Updated: 2013-12-20 16:05:58.366
Author: cvizitiu@gbif.org
Comment: Suggest we close it with "Won't fix": the issue is moot given the fact that we'll switch to new theme/template(s).
Created: 2014-04-07 15:46:41.049
Updated: 2014-04-07 15:46:41.049
Author: bko@gbif.org
Comment: I think we could keep it open for a while in order to check whether it behaves as expected in the new theme. And close this one.
Created: 2014-04-07 16:02:03.626
Updated: 2014-04-07 16:02:03.626
Author: omeyn@gbif.org
Comment: replaced by new drupal theme
Created: 2014-04-14 11:08:21.004
Updated: 2014-04-14 11:08:21.004
