Should OccurrenceService.getKeysByDataset return sth else than an iterator?

12532
Reporter: mdoering
Assignee: omeyn
Type: Improvement
Summary: Should OccurrenceService.getKeysByDataset return sth else than an iterator?
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2012-12-12 14:26:30.652
Updated: 2013-12-06 12:06:41.427
Resolved: 2013-03-06 15:56:04.137
        
Description: The OccurrenceService.getKeysByDataset method in the api returns an iterator which we cannot serialize in json (I guess thats why its not implemented currently). Should this method return a list instead or might it be better to not have it in the API at all but on the occurrence hbase persistence layer? It seems like an internal method.

Iterator getKeysByDataset(UUID datasetKey);]]>
    

Author: omeyn@gbif.org
Comment: I think you're right Markus, this is an internal method and should move into occurrence-persistence. Returning a list has the potential to be devastating (imagine ebird) which is why I prefer Iterator. [~trobertson@gbif.org] what do you think?
Created: 2013-02-21 14:18:52.24
Updated: 2013-02-21 14:18:52.24

Author: omeyn@gbif.org
Comment: Removed from public api and into persistence api.
Created: 2013-03-06 15:56:04.163
Updated: 2013-03-06 15:56:04.163