Issue 15340

Style the Edit Article links

15340
Reporter: bko
Assignee: bko
Type: Story
Summary: Style the Edit Article links
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2014-03-10 17:20:24.166
Updated: 2014-03-27 19:38:44.541
Resolved: 2014-03-27 19:38:38.109
        
Description: The default drupal local task tabs occupy spaces which is unnecessary. We want to provide this for the ease of editors in an efficient way.

Done when:

1) An wikipedia style "edit" link shows after "submitted by…";
2) Only links that are relevant to the role is shown:
  2.1) "view" is not necessary;
  2.2) "devel" is only for dev role.]]>
    

Attachment menu-local-task.png



Author: bko@gbif.org
Created: 2014-03-26 14:59:30.639
Updated: 2014-03-26 14:59:30.639
        
Done as r 2727.

bootstrap module bug reported and the patch submitted at https://drupal.org/node/2226359.
    


Author: bko@gbif.org
Comment: To put menu local task as contextual, we arrange the div inside node.tpl.php through bvng_preprocess_node() and use different classes by altering bvng_menu_local_tasks().
Created: 2014-03-26 15:01:17.464
Updated: 2014-03-26 15:01:17.464


Author: bko@gbif.org
Created: 2014-03-26 17:48:16.847
Updated: 2014-03-26 17:48:52.47
        
The edit link of a news item page/2991 points to taxonomy/term/566/edit, which is NOT the targeted form for editing node/2991. This is not correct and needs to fix.

[~cvizitiu@gbif.org] could you please hint which alias(or token) I should look?
    


Author: cvizitiu@gbif.org
Created: 2014-03-26 18:49:24.234
Updated: 2014-03-26 18:49:24.234
        
[~bko@gbif.org] I don't think I can answer the question as I haven't looked thoroughly into your new menu implementation. The link for editing the page in the administration area is definitely correct, you can check that yourself. So the question should be I guess why is your menu emitting a different link than the administrative page?

If I'm to guess, I'd say it looks as if you're skipping one level in the menu: node/2991 is (or it should be) under (or has a parent) "newsroom" which in turn is indeed taxon/566, but I might be wrong. The link between taxon/566 and newsroom/ comes of course from the taxon's own page but for sure you already know that. 
    


Author: bko@gbif.org
Created: 2014-03-26 20:13:36.977
Updated: 2014-03-26 20:13:36.977
        
Thanks, Cip. For sure an extra eye does help.

The new menu primarily handles the navigation and menu tabs, and I rely on the taxaNavigation field to decide the active menu item, which could be source of faulty reference of contextual links. I'll check that.

The way I implement the gbif_navigation module is to setup an independent custom menu (gbif-menu, footer-links) and route all navigation mechanism from there, so it lives together with the current menu(main-menu), of which we could eventually get rid and simplify the maintenance of the menu. But that's another topic until your review.

Thanks again!
    


Author: bko@gbif.org
Created: 2014-03-27 19:38:20.206
Updated: 2014-03-27 19:38:20.206
        
Fixed as r2728.

Cip, this is relevant to how the active menu item is set. I've documented and provide references in
bvng_preprocess_page() in template.php and gbif_navigation_node_view() in gbif_navigation.module.

Thanks.