Issue 15953

accounts have , in the id

15953
Reporter: trobertson
Assignee: bko
Type: Bug
Summary: accounts have , in the id
Priority: Blocker
Resolution: Fixed
Status: Closed
Created: 2014-06-17 16:59:36.962
Updated: 2014-06-25 15:29:09.487
Resolved: 2014-06-25 15:29:09.453
        
        
Description: I created a new account, then clicked the one time login email link.  Then created a password.  Then clicked on downloads.  Then I notice the URL for the account details page has http://www.gbif-uat.org/user/35,505/edit (note my user ID is 35505).
This has a comma in it and that is a bad URL]]>
    

Attachment Screen Shot 2014-06-25 at 11.16.42 AM.png



Author: mdoering@gbif.org
Comment: Should be fixed by this: https://github.com/gbif/portal-web/commit/19df33db90babfa2237d4ee76318fbc9bc2151c8
Created: 2014-06-25 10:31:21.043
Updated: 2014-06-25 10:31:21.043


Author: bko@gbif.org
Created: 2014-06-25 11:26:10.592
Updated: 2014-06-25 11:43:56.433
        
Thanks Markus - it works! Please see the bottom of the attached image on gbif-dev.

Now can you please also do a quick fix to make the account link consistent? On JavaWeb, that line could be updated from

Hello ${currentUser.firstName!currentUser.accountName!}

to

Hello, ${currentUser.firstName!currentUser.accountName!}!

So "Hello, " is not part of the link, and "/edit" is removed for POR-2192.

Could you please also make this change? Thanks!
    


Author: bko@gbif.org
Created: 2014-06-25 11:48:22.173
Updated: 2014-06-25 11:48:22.173
        
So the current example from the Drupal side which I've just updated to use first name to be consistent with JavaWeb as r2955:

Hello, Logout    
    


Author: mdoering@gbif.org
Comment: done: https://github.com/gbif/portal-web/commit/585c1eff64f258d225bee777cd6434504c5fea89
Created: 2014-06-25 12:35:08.636
Updated: 2014-06-25 12:35:08.636


Author: bko@gbif.org
Comment: Thanks Markus - though the "/edit" still need to be removed...
Created: 2014-06-25 13:23:31.394
Updated: 2014-06-25 13:23:31.394


Author: mdoering@gbif.org
Comment: Ah, didnt see you want it to link to the user/(int) only. ok, will do now
Created: 2014-06-25 14:50:10.072
Updated: 2014-06-25 14:50:10.072


Author: bko@gbif.org
Comment: Yes that will ensure the download tab shown for admin users.
Created: 2014-06-25 14:56:34.269
Updated: 2014-06-25 14:56:34.269


Author: bko@gbif.org
Comment: Confirmed fixed.
Created: 2014-06-25 15:29:09.485
Updated: 2014-06-25 15:29:09.485