Issue 11828

Implement the cube lookup API

11828
Reporter: trobertson
Assignee: trobertson
Type: Bug
Summary: Implement the cube lookup API
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2012-09-12 13:39:26.595
Updated: 2013-12-05 11:05:08.524
Resolved: 2012-09-14 16:03:07.94
        
Description: Implement the agreed API based on the metrics discussion presented on Wiki, discussed and agreed upon [1]


http://dev.gbif.org/wiki/display/POR/Metrics+Discussion]]>
    
Attachment met-9-patch.txt


Author: trobertson@gbif.org
Comment: Attached in met-9-patch.txt is a proposed public API to support this
Created: 2012-09-13 15:41:59.111
Updated: 2012-09-13 15:41:59.111


Author: mdoering@gbif.org
Created: 2012-09-13 16:17:19.501
Updated: 2012-09-13 16:17:51.595
        
Attached a proposed update (met-9-patch.patch) to the good looking metrics api.
The most important changes or questions are:

 - ReadBuilder: use Dimension type matching the primitive argument
 - OccurrenceCube: rename dimension TAXON_ID to NUB_KEY as we use in OccurrenceSearchParameter and elsewhere
 - OccurrenceCube: rename dimension HOST_COUNTRY_ISO to HOST_COUNTRY
 - OccurrenceCube: add DATASET_KEY, NUB_KEY rollup to support metrics on appears in species page block
 - OccurrenceCube: add NUB_KEY, BASIS_OF_RECORD rollup likely be shown on species stats page
 - OccurrenceCube: how would we handle higher taxa counts with a single nub_key dimension? Can the cube handle a list of nub_keys per record?

    


Author: mdoering@gbif.org
Comment: ReadBuilder should at least have some unit tests
Created: 2012-09-13 16:27:08.469
Updated: 2012-09-13 16:27:08.469


Author: trobertson@gbif.org
Created: 2012-09-13 16:32:53.83
Updated: 2012-09-13 16:32:53.83
        
Thanks for the review.

Attached a proposed update (met-9-patch.patch) to the good looking metrics api.

The most important changes or questions are:

ReadBuilder: use Dimension type matching the primitive argument
+1 oops cut n paste error thanks

OccurrenceCube: rename dimension TAXON_ID to NUB_KEY as we use in OccurrenceSearchParameter and elsewhere
-1  It really is not nub key but taxon id, as it can represent kingdom, phylum etc, whereas a nub_key is specifically the single taxon that the occurrence record is identified to.  I will document as such and can call taxon_key if you prefer?

OccurrenceCube: rename dimension HOST_COUNTRY_ISO to HOST_COUNTRY
+1

OccurrenceCube: add DATASET_KEY, NUB_KEY rollup to support metrics on appears in species page block
+1

OccurrenceCube: add NUB_KEY, BASIS_OF_RECORD rollup likely be shown on species stats page
+1

OccurrenceCube: how would we handle higher taxa counts with a single nub_key dimension? Can the cube handle a list of nub_keys per record?
> As above and why I specifically did not use nub_key

ReadBuilder should at least have some unit tests
+1

    


Author: trobertson@gbif.org
Comment: Following discussion, NUB_KEY is to be used as suggested for consistency, but one should know that it can be used for any taxonomic rank
Created: 2012-09-13 16:42:18.337
Updated: 2012-09-13 16:42:18.337


Author: trobertson@gbif.org
Comment: Addresses all comments above.  met-9-patch.txt is suitable for applying to the project root (not workspace root)
Created: 2012-09-14 08:18:18.105
Updated: 2012-09-14 08:18:18.105


Author: trobertson@gbif.org
Comment: With http://code.google.com/p/gbif-common-resources/source/detail?r=1088
Created: 2012-09-14 16:03:08.036
Updated: 2012-09-14 16:03:08.036