Confirm deletion of @Provides NameParser in NubMatchingModule

17814
Reporter: trobertson
Assignee: mdoering
Type: Task
Summary: Confirm deletion of @Provides NameParser in NubMatchingModule
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2015-09-17 11:48:09.407
Updated: 2015-09-17 14:46:03.008
Resolved: 2015-09-17 14:46:02.986
        
Description: checklistbank-nub-ws failed to start reporting double Guice bindings of NameParser.  This is because ChecklistBankServiceMyBatisModule now exposes it due to this commit:

https://github.com/gbif/checklistbank/commit/308f92e4dbff1884ef0f8ca7860ce1f747c4d3e2#diff-c8e7809fb233cfcfd1c781e85efffe45R81

It appears safe to delete the following code, but rather than doing so I have commented it out will reference this jira in a TODO in the code.

[~mdoering] Can you please review this, and remove this code or modify the mybatis module accordingly?

{code}
  @Provides
  @Singleton
  public static NameParser provideParser() {
    NameParser parser = new NameParser();
    return parser;
  }
{code}]]>
    

Author: trobertson@gbif.org
Created: 2015-09-17 11:50:41.06
Updated: 2015-09-17 11:50:41.06
        
https://github.com/gbif/checklistbank/commit/5a17b5cda70685353bb0dabf6b4aae0c1f76543f

    

Author: mdoering@gbif.org
Created: 2015-09-17 14:45:54.503
Updated: 2015-09-17 14:45:54.503
        
Patch confirmed. Here is the one for the mybatis and regular ws module I did earlier:
https://github.com/gbif/checklistbank/commit/5f7790374da572e28fbdb84702060f7035445f7b

The name parser instance now is a bit more heavy, needs some initialisation and should be shared