11305
Reporter: mdoering
Assignee: mdoering
Type: Improvement
Summary: Remove verbatim model classes
Description: Currently the clb api expects that in the future there will be verbatim model classes for every current=interpreted model object. Is this still desired or can we live with just interpreted enums? We don't follow this approach in the registry
Priority: Critical
Resolution: Fixed
Status: Closed
Created: 2012-06-07 12:16:23.835
Updated: 2013-12-09 13:40:57.683
Resolved: 2012-07-11 14:23:47.976
Author: trobertson@gbif.org
Created: 2012-06-07 12:20:39.141
Updated: 2012-06-07 12:20:39.141
I believe InterpretedEnum covers these things better now.
In truth a lot of verbatim stuff gets copied over to interpreted without any interpretation at all, so I believe it makes better sense to do it on a field by field basis. This is surfacing in occurrence as well, as e.g. there is no interpretation of catalog number, locality, collector name etc etc.
If it makes sense to use InterpretedEnum, I think you should go for that. There is no longer strong evidence to suggest we need 2 complete representations unless the UI requires it.
Author: mdoering@gbif.org
Comment: Would it make sense for non enum fields to have a similar class like InterpretedEnum? Right now InterpretedEnum<V, I extends Enum<I>> extends Enum, but does it really have to? Could we not also allow 2 strings to cover non enum use cases, e.g. a normalized scientific name or literature citation or even numerical coordinates and dates?
Created: 2012-06-07 12:26:00.429
Updated: 2012-06-07 12:26:00.429
Author: trobertson@gbif.org
Created: 2012-06-07 12:29:41.07
Updated: 2012-06-07 12:29:41.07
Sounds like a scary change 3 weeks before a release. Why not add InterpretedField for your new needs and just make InterpretedEnum extend InterpretedField?
Author: mdoering@gbif.org
Comment: Good idea, InterpretedField added to common api with InterpretedEnum extending it with an unchanged signature
Created: 2012-06-07 13:00:03.3
Updated: 2012-06-07 13:00:03.3
Author: mdoering@gbif.org
Created: 2012-07-11 13:11:41.551
Updated: 2012-07-11 13:11:41.551
http://code.google.com/p/gbif-ecat/source/detail?r=5231 removed the notion of verbatim model classes.
Only blocking subtasks left to complete.