Issue 10406

Replace TypeSpecimenService.selectByExample()

10406
Reporter: mdoering
Assignee: mdoering
Type: Improvement
Summary: Replace TypeSpecimenService.selectByExample()
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2011-11-15 14:54:23.409
Updated: 2013-12-09 14:01:27.302
Resolved: 2011-12-01 21:51:53.359
        
Description: Replace TypeSpecimenService.selectByExample(...) with a "simple method that takes the needed filter parameters directly.
Call method listXYZ, e.g. listByType or listByFacet according to conventions]]>
    

Attachment Screen Shot 2011-11-17 at 6.08.10 PM.png



Author: kbraak@gbif.org
Created: 2011-11-18 11:20:37.172
Updated: 2011-11-18 11:20:37.172
        
I was about to commit a new simple method called

  public PagingResponse listByTypeStatus(int usageKey, String typeStatus, @Nullable Pageable page) {

The purpose of this method being to filter the type specimens by type status. On the UI, the filter is applied in the right hand sidebar of the type specimen section on the species detail page (see screenshot). The filtered results of type specimens are displayed on a type specimen search page. A question has arisen, however: on the sub-resource search results page, do we want faceting?

Thinking only about type specimens, there aren't so many usually associated to a single usage so displaying them all with no faceting would be fine. This won't always be the case, however, for all subresources like descriptions or images.

Before dealing directly with this issue, perhaps we have to address the more general question about whether we want to facet subresource search pages or not. 
    


Author: kbraak@gbif.org
Comment: In the meantime, I have removed selectByExample from the TypeSpecimenService API, and replaced the filters by type status in the type specimen section of the Portal by simple elements displaying the count by type status. 
Created: 2011-11-21 15:29:43.26
Updated: 2011-11-21 15:29:43.26