Issue 10563

Set DatasetType on Dataset

10563
Reporter: kbraak
Assignee: kbraak
Type: Bug
Summary: Set DatasetType on Dataset
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2011-12-28 15:41:53.227
Updated: 2013-12-16 17:50:17.427
Resolved: 2012-01-16 15:25:23.93
        
Description: A Dataset can be of type Checklist, Occurrence, or External. In order to appropriately display the dataset in the Portal, its DatasetType must be set.

If the type can be inferred from its service(s), these rules could guide implementation:

If the Dataset has service Darwin Core Archive Checklist, it is type Checklist.

If the Dataset has service Darwin Core Archive Occurrence, DiGIR, TAPIR, BioCASE, it is type Occurrence.

If it doesn't have any of the above services, it is type External.  ]]>
    


Author: kbraak@gbif.org
Comment: External dataset types, and some occurrence and checklist types also now being set based on the service type. Please see DatasetFactory for determination of occurrence and checklist dataset type.
Created: 2011-12-29 20:22:22.29
Updated: 2011-12-29 20:22:22.29


Author: kbraak@gbif.org
Comment: The last changeset 1932 actually relates to this issue: http://dev.gbif.org/issues/browse/REG-50
Created: 2012-01-03 14:58:29.918
Updated: 2012-01-03 14:58:29.918


Author: kbraak@gbif.org
Created: 2012-01-04 10:39:25.639
Updated: 2012-01-04 10:39:25.639
        
Provided a resource has a service that categorizes it as CHECKLIST, OCCURRENCE, or METADATA, the type is set fine.

Unfortunately, the registry_staging database on mogo appears to be an incomplete version of what tries to be a dataset aware registry. There are no TAPIR services for example. Therefore, we need to revise the dataset-aware script that generates this database in the first place.

In the meantime, the default dataset type is checklist. Perhaps it would be more prudent to create a new type in the DatasetType enum, however, called UNKNOWN for datasets who's type simply cannot be determined.
    


Author: mdoering@gbif.org
Comment: what about using null for unknown?
Created: 2012-01-16 15:14:44.044
Updated: 2012-01-16 15:14:44.044


Author: kbraak@gbif.org
Comment: Yes, this approach works. Accordingly, I catch the null type in the dataset search and dataset detail freemarker pages and display UNKNOWN. 
Created: 2012-01-16 15:25:00.599
Updated: 2012-01-16 15:25:00.599


Author: kbraak@gbif.org
Comment: Type being confidently set now. Closing issue.
Created: 2012-01-16 15:25:23.953
Updated: 2012-01-16 15:25:23.953