10820
Reporter: kbraak
Assignee: jcuadra
Type: Improvement
Summary: registry-persistence-service: ensure Agent(type=Dataset) citation populated
Priority: Major
Resolution: Fixed
Status: Closed
Created: 2012-02-14 14:52:51.307
Updated: 2013-12-16 17:50:52.856
Resolved: 2012-02-23 00:39:29.567
Description: Currently an agent that is a dataset can have a single extended property, and an extended property has a citation.
Please test whether the agent.extendedProperties.citation is actually populated
If yes, please ensure the DatasetFactory grabs the citation and sets it on Dataset.
If no, investigate why, populate it, and then ensure the DatasetFactory grabs it and sets it on Dataset.]]>
Author: mdoering@gbif.org
Created: 2012-02-14 17:22:28.648
Updated: 2012-02-14 17:22:28.648
Ive added 2 lines to the DatasetFactoryTest in registry-service to test for citation, but as expected its not populated.
See out commented lines 55+56
Author: jcuadra@gbif.org
Created: 2012-02-16 17:20:42.228
Updated: 2012-02-16 17:22:49.048
No factory is dealing with populating citations at this moment.
And a citation can have two fields (identifier and text), so we need to change the underlying DB structure to make room for storing this (Citation is part of the WritableDataset)
So change involves DB structure (liquibase), mappers, and DatasetFactory. I'm taking over this issue.
Later a change in other factories might be needed if we want to include citations for other types of agents.
Author: jcuadra@gbif.org
Created: 2012-02-21 18:23:20.888
Updated: 2012-02-21 18:23:20.888
Citations are being showed now, tests adapted also
Commits on
http://code.google.com/p/gbif-registry/source/detail?r=2230
and
http://code.google.com/p/gbif-registry/source/detail?r=2231
Author: kbraak@gbif.org
Created: 2012-02-22 19:25:49.352
Updated: 2012-02-22 19:25:49.352
Included in the JSON response, is a empty/null Citation meaning that both text and identifier are null.
.
.
citation: { },
According to the coding conventions, we shouldn't be including null elements in the JSON response.