Issue 11027

Create new OccurrenceDataset class?

11027
Reporter: mdoering
Type: Improvement
Summary: Create new OccurrenceDataset class?
Priority: Critical
Resolution: Fixed
Status: Closed
Created: 2012-04-16 11:25:48.997
Updated: 2013-12-16 17:50:40.271
Resolved: 2012-05-31 14:29:32.803
        
Description: For checklist datasets we have created a Dataset subclass holding all specific properties, mainly for metrics.
Should we create a new OccurrenceDataset subclass similar to Checklist or rather ditch Checklist in favor of another shared approach?]]>
    


Author: trobertson@gbif.org
Created: 2012-04-16 11:33:10.53
Updated: 2012-04-16 11:33:10.53
        
Or consider creating a sub resource "Metrics"?

Without knowing the kind of metrics being stored, not sure what is appropriate.  Dataset could explode quickly into a huge object.

- declaredRecordCount
- accessibleRecordCount
- indexableRecordCount
- speciesCount
- taxonCount
- georeferencedCount
etc etc


    


Author: mdoering@gbif.org
Created: 2012-04-16 12:17:17.379
Updated: 2012-04-16 12:17:17.379
        
yes. And we should also agree on a convention for property names for metrics.
We use xyzCount or numXyz already
    


Author: kbraak@gbif.org
Created: 2012-04-16 12:53:01.138
Updated: 2012-04-16 12:53:01.138
        
Simplest I would would be to not subclass Dataset, but add sub-resource Metrics that can be expanded for both Dataset or Checklist metrics (If the Metrics properties are the principal reason why we would like to subclass Dataset).

I was soon going to implement REG-183, so I will hold that until we can discuss this further. 
    


Author: mdoering@gbif.org
Created: 2012-04-16 13:03:16.536
Updated: 2012-04-16 13:03:16.536
        
Looking at the Checklist class in addition to metrics there are these non Dataset properties, they could be candidates for all Datasets:

  private String shortname;
  private Date published;
  private Date lastIndexed;
  private Integer nubPriority;


Checklist does not subclass from Dataset right now btw.
I think it should though and probably be served via the standard dataset API instead of having its own service interface.
The only extra method in their is Checklist get(String short name) which makes sense for all datasets if we move the property to Dataset
    


Author: mdoering@gbif.org
Comment: Its concluded to also remove the Checklist class instead, see issues CLB-110 and REG-221
Created: 2012-05-31 14:29:32.835
Updated: 2012-05-31 14:29:32.835